feat(checkout): support auto-confirmed terms on checkout confirm page#659
Open
ngocblue wants to merge 1 commit into
Open
feat(checkout): support auto-confirmed terms on checkout confirm page#659ngocblue wants to merge 1 commit into
ngocblue wants to merge 1 commit into
Conversation
commit: |
4 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
From v6.8 (
V6_8_0_0) the checkout confirm page no longer shows a mandatory T&C checkbox by default — it's replaced by an auto-confirm summary line. The sharedConfirmTermsAndConditionstask pressed a checkbox that no longer exists, which broke every checkout spec on the next-major run.What
ConfirmTermsAndConditionsnow presses/asserts the checkbox only when it's visible, otherwise it no-ops — so it works unchanged on lower versions and no-ops on the v6.8 default.CheckoutConfirm.termsAutoConfirmedTextlocator (.checkout-confirm-tos-information).autoConfirmTermsTextsnippet (en/de) so specs can assert the new summary text.Consumed by a platform acceptance spec verifying the v6.8 behaviour (shopware/shopware#18176).
Verified
Ran every spec that calls
ConfirmTermsAndConditions()against both versions — all green:FEATURE_ALL=major): checkbox absent → task no-ops, checkout completes.V6_8_0_0off): checkbox present → task presses and asserts it as before.So the change is backward compatible: no behavioural difference on lower versions, and the next-major checkout specs pass again.