fix: support for additional volume mounts#290
Merged
Conversation
Tom Bojer (tombojer)
requested review from
Patrick Derks (TrayserCassa),
Copilot and
Kevin Rudde (kevinrudde)
July 10, 2026 08:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the shopware Helm chart to allow users to inject additional volumes and volumeMounts into the rendered Store resource via values.yaml, enabling custom secret/config mounts beyond the chart’s built-in mounts.
Changes:
- Add optional rendering of
.Values.store.container.volumeMountsinto thevolumeMounts:list intemplates/store.yaml. - Add optional rendering of
.Values.store.container.volumesinto thevolumes:list intemplates/store.yaml. - Document the new values via commented examples in
values.yamland bump chart version metadata.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/shopware/values.yaml | Adds commented examples showing how to configure additional volumes and volumeMounts under store.container. |
| charts/shopware/templates/store.yaml | Appends user-defined store.container.volumeMounts and store.container.volumes into the generated spec. |
| charts/shopware/Chart.yaml | Bumps chart version and appVersion to 1.0.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tom Bojer (tombojer)
marked this pull request as ready for review
July 10, 2026 08:58
Patrick Derks (TrayserCassa)
approved these changes
Jul 10, 2026
Kevin Rudde (kevinrudde)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.