fix(component-library): normalize pasted number separators#1258
Merged
Alastair Fraser (alastair-simon) merged 4 commits intoJul 9, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Jonas Elfering (keulinho)
requested review from
Fabian Hüske (fabianhueske) and
Gerrit Weiermann (gweiermann)
July 7, 2026 09:26
Jonas Elfering (keulinho)
requested review from
Alastair Fraser (alastair-simon) and
Arnold Stoba (arnoldstoba)
July 7, 2026 09:26
Jonas Elfering (keulinho)
marked this pull request as ready for review
July 7, 2026 09:26
5 tasks
Alastair Fraser (alastair-simon)
approved these changes
Jul 7, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/create-meteor-extension
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
Arnold Stoba (arnoldstoba)
approved these changes
Jul 8, 2026
Alastair Fraser (alastair-simon)
deleted the
agent/fix-number-field-pasted-separators
branch
July 9, 2026 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Normalize pasted
MtNumberFieldvalues with mixed decimal and grouping separators.Why?
Pasted values such as
333,33and1.333,33could be parsed inconsistently, causing currency values in Shopware Administration to silently become wrong amounts.How?
The number parser now treats the rightmost
.or,as the decimal separator and removes earlier separators as grouping separators.onInputuses that same parser so editing and blur behavior agree.Testing?
node_modules/.bin/vitest run src/components/mt-number-field/mt-number-field.spec.ts -t "normalizes pasted numbers"Screenshots (optional)
Anything Else?
Reported from shopware/shopware#16901.