fix: component library icon-kit peer major bump#1259
Merged
Alastair Fraser (alastair-simon) merged 2 commits intoJul 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Alastair Fraser (alastair-simon)
changed the title
Alastair Fraser (alastair-simon)
changed the title
Alastair Fraser (alastair-simon)
requested a review
from Jannis Leifeld (jleifeld)
July 7, 2026 13:31
Alastair Fraser (alastair-simon)
requested a review
from Arnold Stoba (arnoldstoba)
July 7, 2026 13:32
Arnold Stoba (arnoldstoba)
approved these changes
Jul 7, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/create-meteor-extension
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
Jannis Leifeld (jleifeld)
approved these changes
Jul 7, 2026
Alastair Fraser (alastair-simon)
deleted the
fix/component-library-icon-kit-peer-major-bump
branch
July 7, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removed @shopware-ag/meteor-icon-kit from the component library's peerDependencies.
Why?
Changesets treats any non-patch bump of a peer dependency as breaking, so an icon-kit minor release wrongly forced a major release of the component library.
How?
Dropping the peer entry lets updateInternalDependencies: "patch" apply instead, so icon-kit minor bumps passed through as patch in component-library. Risks are minimal because the icon kit is still a normal dependency, so it's installed and works exactly as before — nothing about how the icons load actually changes.