Skip to content

feat: add instructree skill - #1251

Open
kotobuki09 wants to merge 2 commits into
sickn33:mainfrom
kotobuki09:feat/add-instructree-skill
Open

feat: add instructree skill#1251
kotobuki09 wants to merge 2 commits into
sickn33:mainfrom
kotobuki09:feat/add-instructree-skill

Conversation

@kotobuki09

Copy link
Copy Markdown

Pull Request Description

Adds the instructree community skill for mapping and linting repository-scoped coding-agent instructions before an agent changes code.

The contribution is pinned to the MIT-licensed Instructree v0.7.0 release, credits the source repository, and keeps generated catalogs and plugin mirrors out of the source PR.

This fills a different role from the existing instruction-authoring skills: it inventories and explains AGENTS.md, CLAUDE.md, Copilot instructions and recursive imports, Agent Skills, custom agents, Cursor rules, and Windsurf rules. The audit is local and read-only, and its limitations avoid claiming universal client precedence.

Change Classification

  • Skill PR
  • Docs PR
  • Infra PR

Issue Link (Optional)

Not applicable.

Quality Bar Checklist ✅

  • Standards: I have read docs/contributors/quality-bar.md and docs/contributors/security-guardrails.md.
  • Metadata: The SKILL.md frontmatter is valid (checked with npm run validate).
  • Risk Label: I assigned risk: safe; the default audit is read-only and the executable fallback requires approval.
  • Triggers: The "When to use" section is clear and specific.
  • Limitations: The skill includes a ## Limitations section.
  • Security: This is not an offensive skill.
  • Safety scan: npm run security:docs passed with the bundled Python runtime selected explicitly.
  • Automated Skill Review: Pending the pull-request workflow.
  • Manual Logic Review: Reviewed the trigger scope, static-analysis boundary, download approval, provenance, and risk: safe classification.
  • Local Test: Instructree v0.7.0 was exercised locally; the repository audit, targeted explanation, and SARIF generation paths work.
  • Repo Checks: npm run validate:references passed.
  • Source-Only PR: Only the canonical skill, source credit, and walkthrough evidence are committed; generated registries and mirrors are excluded.
  • Credits: Added kotobuki09/instructree under Community Contributors.
  • License provenance: Declared MIT with the v0.7.0 license URL.
  • Maintainer Edits: Maintainer edits are enabled on the fork PR.

Validation

  • npm run chain — passed for 2,029 skills
  • npm run check:warning-budget — 0/0
  • npm run check:readme-credits -- --base origin/main --head HEAD — passed
  • npm run validate:references — passed
  • npm run security:docs — passed with PYTHON set to the bundled Python 3.12 runtime
  • npm run pr:evidence ... — non-blocking; zero audit errors/warnings, zero security flags, mode 100644
  • git diff --cached --check — passed before commit

The complete local test runner reaches four pre-existing Windows host-contract failures involving POSIX 0600 mode assertions, symlink privileges, and ACL behavior. This PR changes only Markdown source files; the hosted Linux checks remain the authoritative full-suite gate.

Screenshots (if applicable)

Not applicable.

@kotobuki09
kotobuki09 requested a review from sickn33 as a code owner August 25, 2026 19:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d310a23eb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/instructree/SKILL.md Outdated
If neither is available, explain that the next command downloads executable package code and ask for approval before running the pinned release:

```bash
npx github:kotobuki09/instructree#v0.7.0 scan .

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the executable fallback to the reviewed commit

When no local binary exists, this command makes npx download and execute whatever object the v0.7.0 ref resolves to at invocation time. The installed npm package-spec documentation defines #ref as “a git tag, branch, or other git ref,” so this is not the immutable pin the surrounding guidance claims; if the upstream tag is moved or compromised, users can execute code other than the reviewed 364dddc66badac13a284b79f0dc71f2b4362f6de. Use that full commit SHA in the package spec instead.

AGENTS.md reference: AGENTS.md:L52-L54

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 100fa3a: the executable fallback now pins the reviewed v0.7.0 commit (364dddc66badac13a284b79f0dc71f2b4362f6de) instead of the movable tag. I also applied the same immutable pin to the canonical skill source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant