Skip to content

fix: selinux: allow NFS access - #13987

Closed
dsseng wants to merge 1 commit into
siderolabs:mainfrom
dsseng:se-allow-nfs
Closed

dsseng wants to merge 1 commit into
siderolabs:mainfrom
dsseng:se-allow-nfs

Conversation

@dsseng

@dsseng dsseng commented Aug 6, 2026

Copy link
Copy Markdown
Member

Pods (and other involved components) need NFS (and similar network FS) access when provisioning using CSI drivers that use NFS.

Link: #13938 (not a complete fix)

Pods (and other involved components) need NFS (and similar network FS)
access when provisioning using CSI drivers that use NFS.

Link: siderolabs#13938 (not a complete fix)

Signed-off-by: Dmitrii Sharshakov <dmitry.sharshakov@siderolabs.com>
@github-project-automation github-project-automation Bot moved this to To Do in Planning Aug 6, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Aug 6, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Aug 6, 2026
(allow any_p hugetlbfs_t (fs_classes (rw)))

; NFS and others, frequently used by CSI drivers
(allow any_p network_fs_t (fs_classes (rw)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we only allow containers?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there might be other edge cases where e.g. kubelet needs to interact with the CSI-provisioned volumes. I have not reproduced this issue myself

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could check the audit logs of the longhorn test, it tests an NFS mount

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find any mentions of network_fs_t there, maybe because it's permissive (?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh it's permissive, but there should be logging for denials right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more inclined we reproduce this with some NFS test and rule out a bad program behavior if possible

@shanduur
shanduur requested a review from Copilot August 6, 2026 17:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an SELinux policy allow-rule to enable filesystem RW access to network-backed filesystems (e.g., NFS) that are commonly used by CSI drivers.

Changes:

  • Allow any_p processes RW access to network_fs_t across filesystem classes.
  • Document the intent with an inline policy comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +146 to +147
; NFS and others, frequently used by CSI drivers
(allow any_p network_fs_t (fs_classes (rw)))
@smira

smira commented Sep 9, 2026

Copy link
Copy Markdown
Member

@shanduur did your NFS PR contain a similar fix for the SELinux policy?

@shanduur

shanduur commented Sep 9, 2026

Copy link
Copy Markdown
Member

@smira smira moved this from Approved to On Hold in Planning Sep 14, 2026
@dsseng dsseng closed this Sep 14, 2026
@github-project-automation github-project-automation Bot moved this from On Hold to Done in Planning Sep 14, 2026
@smira smira moved this from Proposed to Refused in Backports to v1.14 Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Refused
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants