refactor(navbar): remove deprecated navbar component#1179
Draft
akashsonune wants to merge 1 commit into
Draft
Conversation
akashsonune
commented
Dec 10, 2025
Member
- I confirm that this MR follows the contribution guidelines.
1c145c2 to
9397ff5
Compare
|
Documentation. Coverage Reports: |
9397ff5 to
6c39f19
Compare
BREAKING CHANGE: Removed the deprecated `SiNavbarModule`. Use the new `si-application-header` instead.
6c39f19 to
1e09422
Compare
Member
Author
|
@spike-rabbit do we want to delay this one or merge for 49? |
Member
Author
@spike-rabbit WDYT? |
Member
|
yes, we should at least wait until then |
Member
Author
|
ok lets park it for v50 for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.