Skip to content

refactor(element-ng): replace btn-ghost with btn-tertiary-ghost#1993

Merged
dr-itz merged 1 commit into
mainfrom
refactor/ghost-button-tertiary
May 1, 2026
Merged

refactor(element-ng): replace btn-ghost with btn-tertiary-ghost#1993
dr-itz merged 1 commit into
mainfrom
refactor/ghost-button-tertiary

Conversation

@ljanner

@ljanner ljanner commented May 1, 2026

Copy link
Copy Markdown
Member

Migrate all internal usages of .btn-ghost to .btn-tertiary-ghost to prepare for the upcoming naming convention alignment where .btn-ghost will represent the primary ghost style.

Related to #1882 (comment)


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@ljanner ljanner self-assigned this May 1, 2026
@ljanner ljanner added this to the 49.x milestone May 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the button styling from btn-ghost to btn-tertiary-ghost across the library's components, documentation, and test suites. Feedback was provided to address accessibility issues in several templates where interactive elements lacked descriptive ARIA labels or were incorrectly hidden from screen readers.

Comment thread projects/element-ng/pills-input/si-input-pill.component.html Outdated
Comment thread projects/element-ng/tabs/si-tab.component.html
Comment thread src/app/examples/buttons/buttons.html
Migrate all internal usages of `.btn-ghost` to `.btn-tertiary-ghost`
to prepare for the upcoming naming convention alignment where
`.btn-ghost` will represent the primary ghost style.

Related to #1882 (comment)
@ljanner ljanner force-pushed the refactor/ghost-button-tertiary branch from f9418a2 to 59ea70a Compare May 1, 2026 09:26
@ljanner ljanner marked this pull request as ready for review May 1, 2026 09:50
@ljanner ljanner requested review from a team as code owners May 1, 2026 09:50
@ljanner ljanner requested a review from dr-itz May 1, 2026 09:50

@dr-itz dr-itz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dr-itz dr-itz added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 1, 2026
@dr-itz dr-itz added this pull request to the merge queue May 1, 2026
Merged via the queue into main with commit 342b3fd May 1, 2026
17 checks passed
@dr-itz dr-itz deleted the refactor/ghost-button-tertiary branch May 1, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants