feat(dashboards-ng): support bulk add from widget catalog#2033
Open
chintankavathia wants to merge 1 commit into
Open
feat(dashboards-ng): support bulk add from widget catalog#2033chintankavathia wants to merge 1 commit into
chintankavathia wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a bulk selection feature to the widget catalog, allowing users to add multiple widgets to the dashboard simultaneously. The implementation includes UI updates for bulk mode, state management using signals, and updated event emitters. Feedback focuses on ensuring the parent component correctly binds to the new bulk output, preventing unintended selection toggles during search or initialization, and refining the CdkListbox integration and type definitions for better type safety and accessibility.
chintankavathia
force-pushed
the
feat/dashboards-ng/bulk-add
branch
6 times, most recently
from
3683127 to
6f608d6
Compare
Member
Author
|
@panch1739 Please have a look. |
panch1739
reviewed
May 12, 2026
panch1739
left a comment
panch1739
left a comment
Member
There was a problem hiding this comment.
@chintankavathia Question, the bulk action button is just for demo purposes? Otherwise we should just have the checkboxes always there 🤔
Member
Author
No its part of the component. I had to keep that explicitly because widgets which requires configurations can not be selected for bulk add. Let me know if you have a better way to handle that situation |
chintankavathia
force-pushed
the
feat/dashboards-ng/bulk-add
branch
5 times, most recently
from
68b050a to
213675f
Compare
chintankavathia
added
the
breaking-changes
chintankavathia
force-pushed
the
feat/dashboards-ng/bulk-add
branch
2 times, most recently
from
a465285 to
3b38089
Compare
Adds an opt-in multi-select mode to the widget catalog, letting users
pick several widgets and add them to a dashboard in one go instead of
opening the catalog once per widget.
To enable it, set `enableMultiSelect` on `<si-flexible-dashboard>`:
```
<si-flexible-dashboard
[widgetCatalog]="widgets"
[enableMultiSelect]="true"
/>
```
When enabled, the catalog shows selectable items and a confirmation
action that adds all chosen widgets to the dashboard at once. The
default single-select behavior is unchanged when the flag is omitted.
To support widgets that need configuration before they can render, a
new optional `setupPending` property has been added to `WidgetConfig`.
When `setupPending` is `true`, the dashboard renders a placeholder for
that widget and prompts the user to complete setup. Once the user
confirms the configuration, `setupPending` flips to `false` and the
placeholder is replaced by the actual widget instance. This keeps the
bulk-add flow fast while still allowing widgets that require user
input to be configured afterwards.
DEPRECATED: `SiWidgetCatalogComponent.selected` is deprecated in favor
of `selectedWidgets` and `hasSelection`. The old property only ever
holds the first selected widget and is not updated in multi-select
mode. It will be removed in one of the next major releases. Only
relevant if you extend `SiWidgetCatalogComponent`.
```
BREAKING CHANGE: `SiWidgetCatalogComponent.closed` signature changed
from `output<Omit<WidgetConfig, 'id'> | undefined>` to
`output<Omit<WidgetConfig, 'id'>[] | undefined>`. In single-select mode
the array always contains exactly one entry.
This only affects code that either:
- subclasses `SiWidgetCatalogComponent` and overrides `closed` or
calls `this.closed.emit(...)`, or
- uses `<si-widget-catalog>` directly in a template and subscribes
to `(closed)`.
Migration for subclasses:
- Update overridden output type to
`Omit<WidgetConfig, 'id'>[] | undefined`.
- Wrap `emit(config)` calls as `emit([config])`.
Migration for direct template consumers:
Before:
```
onClosed(config: Omit<WidgetConfig, 'id'> | undefined) {
if (config) this.addWidget(config);
}
```
After:
```
onClosed(configs: Omit<WidgetConfig, 'id'>[] | undefined) {
configs?.forEach(config => this.addWidget(config));
}
```
chintankavathia
force-pushed
the
feat/dashboards-ng/bulk-add
branch
from
3b38089 to
cef677c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in multi-select mode to the widget catalog, letting users pick several widgets and add them to a dashboard in one go instead of opening the catalog once per widget.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: