Feat/add pinned items to inline collapsed#2141
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements an inline-collapse feature for the vertical navbar, allowing the active root-level item and any pinned items to render as chips next to the toggle button when collapsed. It updates the group trigger directive to dynamically adjust its overlay positioning strategy and ensures accessibility landmarks are preserved. Feedback on the changes includes addressing a missing chipMode signal in the item component's unit tests to prevent runtime errors, removing redundant optional chaining on the guaranteed overlayRef in the group trigger directive, and leveraging Angular's @let syntax in the navbar template to simplify references to activeItem().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fffd4da to
76219e9
Compare
b8bfed3 to
4d31c3d
Compare
76219e9 to
ff68996
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a pinned input to the vertical navbar items, allowing specific items to remain visible in the inline-collapse chip slot alongside the active item. The layout is updated to a flex row to support multiple chips side-by-side, with pinned chips hidden on small screens. Feedback on these changes includes a recommendation to remove non-null assertions in the template by leveraging Angular's type inference in @if blocks, a correction to the JSDoc for the pinned input to accurately reflect the responsive SCSS behavior, and a request to add unit tests for the new pinning logic to comply with the repository's contribution guidelines.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a pinned input to the vertical navigation bar items, allowing specific items to remain visible in the inline-collapse chip slot alongside the active item. The layout styles, component templates, and unit tests have been updated to support and verify this multi-chip behavior. Feedback on the changes suggests using an explicit comparison for pinnedItems().length in the template's @if condition to avoid implicit type coercion, and removing an unnecessary non-null assertion operator on activeItem since its type is already narrowed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
9dbb78c to
a0710a0
Compare
fe13d48 to
3c049ed
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a pinned input to the vertical navbar items, allowing specific root-level items to remain visible in the inline-collapse chip slot alongside the active item. The changes include layout adjustments, SCSS updates, and comprehensive unit tests. Feedback suggests updating the media query breakpoint from media-breakpoint-down(sm) to media-breakpoint-down(md) to correctly target screen widths of sm and below in accordance with Bootstrap 5 conventions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…inline-collapse chip slot Items with `[pinned]="true"` appear as fixed chips in the inline-collapse bar alongside the active chip. Pinned items are hidden at sm and below. Related #1945
47796c6 to
1d09ba5
Compare
[pinned]="true"appear as fixed chips in the inline-collapse bar alongside the active chip.Related #1945
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: