Skip to content

Feat/add pinned items to inline collapsed#2141

Open
mistrykaran91 wants to merge 1 commit into
mainfrom
feat/add-pinned-items-to-inline-collapsed
Open

Feat/add pinned items to inline collapsed#2141
mistrykaran91 wants to merge 1 commit into
mainfrom
feat/add-pinned-items-to-inline-collapsed

Conversation

@mistrykaran91

@mistrykaran91 mistrykaran91 commented Jun 10, 2026

Copy link
Copy Markdown
Member
  • add pinned input to always show items in inline-collapse chip slot
  • items with [pinned]="true" appear as fixed chips in the inline-collapse bar alongside the active chip.
  • pinned items are hidden at sm and below.

Related #1945


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements an inline-collapse feature for the vertical navbar, allowing the active root-level item and any pinned items to render as chips next to the toggle button when collapsed. It updates the group trigger directive to dynamically adjust its overlay positioning strategy and ensures accessibility landmarks are preserved. Feedback on the changes includes addressing a missing chipMode signal in the item component's unit tests to prevent runtime errors, removing redundant optional chaining on the guaranteed overlayRef in the group trigger directive, and leveraging Angular's @let syntax in the navbar template to simplify references to activeItem().

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/navbar-vertical-next/si-navbar-vertical-next.component.html Outdated
@mistrykaran91 mistrykaran91 force-pushed the feat/navbar-vertical-next-inline-collapse-active-item-without-template branch from fffd4da to 76219e9 Compare June 10, 2026 06:22
@mistrykaran91 mistrykaran91 force-pushed the feat/add-pinned-items-to-inline-collapsed branch from b8bfed3 to 4d31c3d Compare June 10, 2026 06:29
@mistrykaran91 mistrykaran91 force-pushed the feat/navbar-vertical-next-inline-collapse-active-item-without-template branch from 76219e9 to ff68996 Compare June 10, 2026 06:46
@mistrykaran91

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pinned input to the vertical navbar items, allowing specific items to remain visible in the inline-collapse chip slot alongside the active item. The layout is updated to a flex row to support multiple chips side-by-side, with pinned chips hidden on small screens. Feedback on these changes includes a recommendation to remove non-null assertions in the template by leveraging Angular's type inference in @if blocks, a correction to the JSDoc for the pinned input to accurately reflect the responsive SCSS behavior, and a request to add unit tests for the new pinning logic to comply with the repository's contribution guidelines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/navbar-vertical-next/si-navbar-vertical-next.component.html Outdated
@mistrykaran91

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pinned input to the vertical navigation bar items, allowing specific items to remain visible in the inline-collapse chip slot alongside the active item. The layout styles, component templates, and unit tests have been updated to support and verify this multi-chip behavior. Feedback on the changes suggests using an explicit comparison for pinnedItems().length in the template's @if condition to avoid implicit type coercion, and removing an unnecessary non-null assertion operator on activeItem since its type is already narrowed.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/navbar-vertical-next/si-navbar-vertical-next.component.html Outdated
Comment thread projects/element-ng/navbar-vertical-next/si-navbar-vertical-next.component.html Outdated
@mistrykaran91 mistrykaran91 marked this pull request as ready for review June 10, 2026 11:44
@mistrykaran91 mistrykaran91 requested review from a team as code owners June 10, 2026 11:44
@mistrykaran91 mistrykaran91 force-pushed the feat/navbar-vertical-next-inline-collapse-active-item-without-template branch 7 times, most recently from 9dbb78c to a0710a0 Compare June 12, 2026 09:21
Base automatically changed from feat/navbar-vertical-next-inline-collapse-active-item-without-template to main June 15, 2026 06:24
@mistrykaran91 mistrykaran91 force-pushed the feat/add-pinned-items-to-inline-collapsed branch 2 times, most recently from fe13d48 to 3c049ed Compare June 17, 2026 08:36
@mistrykaran91

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pinned input to the vertical navbar items, allowing specific root-level items to remain visible in the inline-collapse chip slot alongside the active item. The changes include layout adjustments, SCSS updates, and comprehensive unit tests. Feedback suggests updating the media query breakpoint from media-breakpoint-down(sm) to media-breakpoint-down(md) to correctly target screen widths of sm and below in accordance with Bootstrap 5 conventions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…inline-collapse chip slot

Items with `[pinned]="true"` appear as fixed chips in the inline-collapse
bar alongside the active chip. Pinned items are hidden at sm and below.

Related #1945
@mistrykaran91 mistrykaran91 force-pushed the feat/add-pinned-items-to-inline-collapsed branch from 47796c6 to 1d09ba5 Compare June 17, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant