Skip to content

kas-container: Fix podman detection#169

Open
DiogoSilva14 wants to merge 1 commit intosiemens:masterfrom
DiogoSilva14:master
Open

kas-container: Fix podman detection#169
DiogoSilva14 wants to merge 1 commit intosiemens:masterfrom
DiogoSilva14:master

Conversation

@DiogoSilva14
Copy link
Copy Markdown

When "docker -v" is ran and podman docker compatibility is enabled, podman will report the version string as "docker version x.x.x". Due to this the check will fail and report unknown engine.

image

When "docker -v" is ran and podman docker compatibility is enabled,
podman will report the version string as "docker version x.x.x". Due to
this the check will fail and report unknown engine.
@jan-kiszka
Copy link
Copy Markdown
Collaborator

Thanks for this fix. Please submit to the mainling list for further discussions if possible.

Note already that you are changing the default if both podman and docker are installed, and that should be avoided or done explicitly (with reasoning).

@jan-kiszka
Copy link
Copy Markdown
Collaborator

Just had a look at this again but on Debian. There is seems this enhanced emulation mode does not exist. Is it Nix-specific?

Anyway, please follow up on my remarks, provide a signed-off patch (CONTRIBUTING.md), via the mailing list or at least here (will mirror it for you then). Thanks.

@DiogoSilva14
Copy link
Copy Markdown
Author

Sorry, I forgot about this PR...

This seems to be the behavior when Docker compatibility is just done by using a symlink. At least it's what it looks like nix does

I tested with a fedora container and I get the same behavior:

image

It looks like podman just uses $0 when identifying the version.

I will sign the patch and send to the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants