[mod_spandsp] Fix T.38 fax hangup after Phase E completion - #3107
Open
fsliwenjie wants to merge 1 commit into
Open
[mod_spandsp] Fix T.38 fax hangup after Phase E completion#3107fsliwenjie wants to merge 1 commit into
fsliwenjie wants to merge 1 commit into
Conversation
When a T.38 fax completes (Phase E), phase_e_handler() sets pvt->done = 1 to signal the main loop to exit. However, in T.38/UDPTL mode the peer stops sending packets after completion, causing read_frame() to block in poll(). The main loop never reaches the pvt->done check and the call hangs until the media inactivity timeout (up to 600 seconds). Fix: call switch_core_session_kill_channel(session, SWITCH_SIG_BREAK) after setting pvt->done = 1 to wake the blocked read_frame(). The same pattern exists in mod_spandsp_fax_stop_fax(), which is also fixed. Closes signalwire#3044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a T.38 fax completes (Phase E),
phase_e_handler()setspvt->done = 1to signal the main loop inmod_spandsp_fax_process_fax()to exit. However, in T.38/UDPTL mode the peer stops sending packets after completion, causingread_frame()to block inpoll(). The main loop never reaches thepvt->donecheck and the call hangs until the media inactivity timeout (up to 600 seconds).This fix calls
switch_core_session_kill_channel(session, SWITCH_SIG_BREAK)after settingpvt->done = 1to wake the blockedread_frame().The same
pvt->done = 1pattern exists inmod_spandsp_fax_stop_fax(), which is also fixed to prevent the same hangup issue.Type of Change
Related Issues
Closes #3044
Testing