fix: use terminal yellow instead of hardcoded orange in shell exec output#1512
Open
octo-patch wants to merge 1 commit into
Open
fix: use terminal yellow instead of hardcoded orange in shell exec output#1512octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
…tput (fixes sigoden#1475) Replace the hardcoded RGB orange color (255, 165, 0) with the existing warning_text() helper which uses the terminal's native Yellow color. This integrates with the user's color theme and respects NO_COLOR. Co-Authored-By: Octopus <liyuan851277048@icloud.com>
ei-grad
added a commit
to ei-grad/aichat
that referenced
this pull request
Jul 11, 2026
Add an explicit --files list grammar for shell-expanded inputs while preserving the established single and repeated -f behavior. This avoids classifying positional prompt tokens by filesystem existence and makes the file/prompt boundary explicit. Apply command preludes before --info with defined REPL fallback semantics, parse editor commands into an executable plus arguments without invoking a shell, and reuse that parser for REPL buffer editing. Move local image reads to Tokio, use the configured warning color for generated shell commands, and document installation and local-agent layouts. Adapt the bounded fixes discussed in: sigoden#1451 sigoden#1509 sigoden#1534 sigoden#1533 sigoden#1512 sigoden#1525 sigoden#1383 sigoden#1437 sigoden#1486 Co-Authored-By: Codex CLI <noreply@openai.com>
ei-grad
added a commit
to ei-grad/aichat
that referenced
this pull request
Jul 11, 2026
Integrate the exact upstream PR head and preserve its original author and co-author attribution. Generated shell commands now use the configured warning style instead of a hard-coded RGB orange. Source: sigoden#1512 Head: 706d052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1475
Problem
The shell exec command display uses a hardcoded RGB orange color
(255, 165, 0)which conflicts with many terminal color themes and ignores the user's color preferences.Solution
Replace the hardcoded
color_text(eval_str.trim(), nu_ansi_term::Color::Rgb(255, 165, 0))with the existingwarning_text()helper, which uses the terminal's nativeYellowcolor. This:NO_COLORenvironment variable (already handled bycolor_text/warning_text)Testing
Built and verified the code compiles cleanly. The shell exec (
aichat -e) command display now uses the terminal's yellow color instead of the hardcoded orange.