fix(config): respect $EDITOR when config editor is unset#1531
Closed
syf2211 wants to merge 0 commit into
Closed
Conversation
96204b5 to
82976d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
editoris not set inconfig.yaml, aichat should use$VISUALor$EDITORbefore falling back tonano/notepad.Motivation
Fixes #1527. After #1082,
Config::editor()validated the resolved editor withwhich::which(). If$EDITORpointed to a valid editor thatwhichcould not resolve (common with custom install paths or editor commands with arguments), resolution failed and REPL editing fell back tonano.Changes
resolve_editor()with priority: config →VISUAL→EDITOR→ platform fallbackwhichchecknano/notepadfallback withwhichshell_wordsinedit_fileand REPL buffer editorTests
cargo testAll 26 tests pass.
Notes
Blank/whitespace
editor:values in config are treated as unset so$EDITORis honored.