Feature gate ring for Miri support - #15
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 70 70
=======================================
Hits 35 35
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Unfortunately it's hard to get better coverage here without providing another feature flag to disable |
|
Thank you for this change. I'm in a similar situation where I can't use ring as a dependency and thus had to use a custom API compatible implementation without it (because a dependency used it). |
|
Glad to hear! What are you working on these days @DragonDev1906? |
|
Ethereum block verification in a TEE, which does use ssz + tree_hash. And ring unfortunately doesn't support the Used to build data bridging for other chains by checking its integrity in the TEE and signing the response, and to detect on-chain events for use in TEE-based L2+bridging. |
Ring contains a call to
OPENSSL_cpuid_setupwhich is not supported by Miri [it can't handle most FFI].This PR feature-gates
ringso that we can buildethereum_hashingwithout it. This enables us to run the test suites fortree_hashandssz_typesusing Miri, which is increasingly important with the introduction ofunsafecode in:This change is unfortunately not backwards-compatible, as downstream users compiling with
default-features = falsemight have their build broken by the exclusion ofring(on a non-x86_64 platform). Therefore this PR necessitates a minor version bump.