Use multi-arch image for Trillian's netcat initContainer#482
Open
codysoyland wants to merge 4 commits into
Open
Use multi-arch image for Trillian's netcat initContainer#482codysoyland wants to merge 4 commits into
codysoyland wants to merge 4 commits into
Conversation
hectorj2f
reviewed
Mar 8, 2023
sabre1041
requested changes
Apr 3, 2023
sabre1041
left a comment
sabre1041
left a comment
Contributor
There was a problem hiding this comment.
Can this reference be also updated
https://github.com/sigstore/helm-charts/blob/main/charts/trillian/Chart.yaml#L28-L29
sabre1041
requested changes
Apr 3, 2023
sabre1041
left a comment
sabre1041
left a comment
Contributor
There was a problem hiding this comment.
Can this reference be also updated
https://github.com/sigstore/helm-charts/blob/main/charts/trillian/Chart.yaml#L28-L29
Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
force-pushed
the
trillian-netcat-image-multiarch
branch
from
c264020 to
7b442a2
Compare
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
force-pushed
the
trillian-netcat-image-multiarch
branch
from
7b442a2 to
5eb8426
Compare
Contributor
|
@codysoyland is this still something you care about? Could you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This replaces
toolbelt/netcatwith the standardalpinemulti-arch image, which makes this chart compatible with non-amd64 architectures. The alpine image includes thenccommand.Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.