override fulcio server secret keys#501
Open
saisatishkarra wants to merge 1 commit into
Open
Conversation
Signed-off-by: saisatish karra <saisatish.karra@konghq.com>
Contributor
|
Cc @vaikas |
cpanato
reviewed
Apr 5, 2023
cpanato
left a comment
cpanato
left a comment
Member
There was a problem hiding this comment.
this might be a breaking change, did you test this upgrade with an existing installation?
Contributor
Author
|
@cpanato I haven't verified this change against the existing instance!! can you point me to docs to test it out? |
Contributor
Author
|
@haydentherapper @cpanato please update the next course of action items if any changes are to be made/tested against to move this forward. |
Contributor
|
The change of the secret value a string to an object isn't backwards compatible. If this is still something you care about, could you rebase and look into creating a migration path that won't break existing deployments that override that secret value? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Existing or Associated Issue(s)
Fix to partially overcome: sigstore/scaffolding#546
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.