Make cleanup-leases security context configurable#587
Conversation
sirisaacnuketon
force-pushed
the
feat/configurableSecurityContext
branch
from
5ee062e to
9c0675c
Compare
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
need rebase
and need to add the possible or sample values for the security context in a comment in the values.yaml for users to know what they can use
sirisaacnuketon
force-pushed
the
feat/configurableSecurityContext
branch
2 times, most recently
from
c32ccd6 to
de1e772
Compare
| - -c | ||
| - kubectl delete leases --all --ignore-not-found -n {{ .Release.Namespace }} | ||
| restartPolicy: OnFailure | ||
| {{- if .Values.leasescleanup.securityContext.enabled }} |
There was a problem hiding this comment.
you might dont need the enabled variable, just to check if the object exists should be fine
There was a problem hiding this comment.
I was trying to conform to the style used elsewhere in the helm chart, I'm happy to change it however if consistency isn't as important
sirisaacnuketon
force-pushed
the
feat/configurableSecurityContext
branch
2 times, most recently
from
4125424 to
3269ce5
Compare
hectorj2f
left a comment
hectorj2f
left a comment
There was a problem hiding this comment.
LGTM overall, just few minor changes.
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
please update the code to check Hector's comments
thank you!
The SecurityContext field for this job is currently static, however when deploying policy-controller into a namespace that uses Pod Security Admission controllers this job will not be able to run. Signed-off-by: Simon Witheridge <simon.witheridge@sainsburys.co.uk>
sirisaacnuketon
force-pushed
the
feat/configurableSecurityContext
branch
from
3269ce5 to
8ea867a
Compare
|
@sirisaacnuketon Please, could you fix the conflicts? |
|
@sirisaacnuketon do you still want this? Could you rebase? |
5 participants
Description of the change
The SecurityContext field for this job is currently static, however when deploying policy-controller into a namespace that uses Pod Security Admission controllers this job will not be able to run.
This adds a new field to the values file that operates in a manner similar to the
securityContextoption for the webhook deployment.Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.