Fulcio: add app.kubernetes.io labels and additionalLabels support #956
Open
nlamirault wants to merge 3 commits into
Open
Fulcio: add app.kubernetes.io labels and additionalLabels support #956nlamirault wants to merge 3 commits into
nlamirault wants to merge 3 commits into
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
cmurphy
reviewed
Jun 3, 2026
| {{- define "fulcio.labels" -}} | ||
| helm.sh/chart: {{ include "fulcio.chart" . }} | ||
| {{ include "fulcio.selectorLabels" . }} | ||
| app.kubernetes.io/component: fulcio |
Contributor
There was a problem hiding this comment.
Could this be
Suggested change
| app.kubernetes.io/component: fulcio | |
| app.kubernetes.io/component: {{ .Values.server.name | quote }} |
to be consistent with the other charts?
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/part-of: fulcio | ||
| {{- if .Values.additionalLabels }} |
Contributor
There was a problem hiding this comment.
I don't think you want to delete this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.