Add KMS signer support for AWS, GCP, Azure, and file-based backends#597
Open
SequeI wants to merge 1 commit intosigstore:mainfrom
Open
Add KMS signer support for AWS, GCP, Azure, and file-based backends#597SequeI wants to merge 1 commit intosigstore:mainfrom
SequeI wants to merge 1 commit intosigstore:mainfrom
Conversation
This commit adds support for signing models using Key Management Service (KMS) providers through KMS URIs. The implementation follows the same pattern as the existing PKCS11 signer, providing a consistent interface for raw signer instantiations. The KMS signer supports multiple cloud providers: - AWS KMS: `kms://aws/<key-id/key-arn>?region=<region>` - Google Cloud KMS: `kms://gcp/<project>/<location>/<keyring>/<key>` - Azure Key Vault: `kms://azure/<vault-url>/<key-name>?version=<version>` - File backend: `kms://file/<path>` (for local testing) Signed-off-by: SequeI <asiek@redhat.com>
Collaborator
|
Quick drive-by comment - Are there concrete use cases for the chosen KMS providers, or is this to mirror what's available in the Go libraries? We've had some challenges supporting Azure and AWS because the public infrastructure doesn't use these, and we have no test infrastructure to verify functionality. If no one is asking for these, I'd limit which KMS providers are supported. |
Member
|
+1, let's only add the support here when there is a significant need for this. It's for the same reason why #148 is still open, but because we haven't yet seen an actual demand to hash models while they are on remote blob storage we did not spend cycles to implement it. |
mihaimaruseac
added
the
discusion pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds support for signing models using Key Management Service (KMS) providers through KMS URIs. The implementation follows the same pattern as the existing PKCS11 signer, providing a consistent interface for raw signer instantiations.
The KMS signer supports multiple cloud providers:
kms://aws/<key-id/key-arn>?region=<region>kms://gcp/<project>/<location>/<keyring>/<key>kms://azure/<vault-url>/<key-name>?version=<version>kms://file/<path>(for local testing)Closes #203
Tested file and AWS file backends, did not test Azure or GCP as I do not have an account. It should more or less be correct for those KMS backends though (minor fixes perhaps)
Moved some testing resources and the check EC curve functions to not duplicate
Added tests for KMS
Checklist