Change default CLI upload type to hashedrekord#2885
Open
Hayden-IO wants to merge 1 commit into
Open
Conversation
This change sets the default `--type` flag to `hashedrekord` in rekor-cli, along with changing the default `--pkiFormat` flag to x509 (which is certificates and public keys). This is done in a backwards compatible way, in that a client can continue to pass an artifact via --artifact and it will automatically be hashed if the type is hashedrekord. While the PKI flag change is a breaking change, I doubt anyone was using pgp, which was the default. Signed-off-by: Hayden <8418760+Hayden-IO@users.noreply.github.com>
Contributor
Author
|
Verify this works with: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
===========================================
- Coverage 66.46% 18.79% -47.67%
===========================================
Files 92 191 +99
Lines 9258 20344 +11086
===========================================
- Hits 6153 3824 -2329
- Misses 2359 16013 +13654
+ Partials 746 507 -239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change sets the default
--typeflag tohashedrekordin rekor-cli, along with changing the default--pki-formatflag tox509(which is certificates and public keys).This is done in a backwards compatible way, in that a client can continue to pass an artifact via --artifact and it will automatically be hashed if the type is hashedrekord.
While the PKI flag change is a breaking change, I doubt anyone was using pgp, which was the default.
Release Note
Documentation