fix: properly display date and time placeholders for DateTimeRangeFilter#112
Open
jsheffie wants to merge 20 commits into
Open
fix: properly display date and time placeholders for DateTimeRangeFilter#112jsheffie wants to merge 20 commits into
jsheffie wants to merge 20 commits into
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 87.45% 86.70% -0.75%
==========================================
Files 9 9
Lines 606 617 +11
==========================================
+ Hits 530 535 +5
- Misses 76 82 +6 ☔ View full report in Codecov by Sentry. |
Owner
|
Look nice! Thanks you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #113
Changes:
contrib/admin/widgets.py:AdminSplitDateTimeand made two changes:date_attrsandtime_attrsand pass them down to the subwidgets.argsto this init callforms.MultiWidget.__init__(self, widgets)Status:
Alright, this is working for Django 4.2 and above.
I am currently trying to figure out how to make this work on older versions of django.
Visualize
📸 Before: displays 'date' in the time fields
📸 After: displays 'time' in the time fields