TT-7038 PlanTabSelect doesn't includ Assignments for Personal projects#247
Merged
sarahentzel merged 1 commit intodevelopfrom Apr 13, 2026
Merged
TT-7038 PlanTabSelect doesn't includ Assignments for Personal projects#247sarahentzel merged 1 commit intodevelopfrom
sarahentzel merged 1 commit intodevelopfrom
Conversation
Contributor
gtryus
commented
Apr 8, 2026
- Introduced a fixture for plan tab strings to streamline localization.
- Updated memory mock to align with DataProvider for better testing.
- Enhanced option handling in the dropdown to conditionally display items based on team type and offline status.
- Simplified state management and improved readability in the component's logic.
- Added tests to ensure correct rendering and functionality of the PlanTabSelect component.
- Introduced a fixture for plan tab strings to streamline localization. - Updated memory mock to align with DataProvider for better testing. - Enhanced option handling in the dropdown to conditionally display items based on team type and offline status. - Simplified state management and improved readability in the component's logic. - Added tests to ensure correct rendering and functionality of the PlanTabSelect component.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Plan sheet tab dropdown (PlanTabSelect) to conditionally include the Assignments option only when applicable (non-personal teams and not offline-only), and expands Cypress coverage to validate the updated behavior.
Changes:
- Add team/offline-aware option building in
PlanTabSelect(hide Assignments for personal teams and offline-only mode). - Adjust tab/option index resolution so the button label stays consistent when Assignments is hidden.
- Refactor and expand Cypress component tests with an Orbit memory mock that supports
useOrbitData('organization').
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/renderer/src/components/Sheet/PlanTabSelect.tsx |
Builds dropdown options based on team type + offlineOnly and maps tab indices to displayed option labels. |
src/renderer/src/components/Sheet/PlanTabSelect.cy.tsx |
Adds fixtures/memory mocking to support useOrbitData, and adds coverage for personal-team + offline-only behavior. |
Comments suppressed due to low confidence (1)
src/renderer/src/components/Sheet/PlanTabSelect.tsx:71
aria-ownsis set to'action-menu', but the actual<Menu>id is'import-export-menu'. This breaks the ARIA ownership relationship (screen readers rely on the referenced id) and makes the attribute misleading. Align these by either changingaria-ownsto reference the menu id, or renaming the menu id to match.
<AltButton
id="planTabSelect"
aria-owns={actionMenuItem ? 'action-menu' : undefined}
aria-label={t.sectionsPassages}
onClick={handleMenu}
>
{options[optionIndex] ?? options[0]}
<DropDownIcon sx={{ ml: 1 }} />
</AltButton>
<Menu
id="import-export-menu"
anchorEl={actionMenuItem}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sarahentzel
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.