Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 70.41% 70.42%
=======================================
Files 386 386
Lines 32204 32204
Branches 4531 4531
=======================================
+ Hits 22677 22680 +3
+ Misses 8480 8478 -2
+ Partials 1047 1046 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Is there a unit test that covers the bug we are fixing here?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
Enkidu93
left a comment
There was a problem hiding this comment.
Done. Sorry for the delay - it took me way longer than it should have to find a minimal test to cause this to happen. I confirmed that this test fails when run with the previous code.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @johnml1135)
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
This change is