Skip to content

Bug in NParallelTextCorpus#290

Merged
Enkidu93 merged 2 commits intomasterfrom
wa_e2e_fixes
Mar 7, 2025
Merged

Bug in NParallelTextCorpus#290
Enkidu93 merged 2 commits intomasterfrom
wa_e2e_fixes

Conversation

@Enkidu93
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 commented Mar 6, 2025

This change is Reviewable

@Enkidu93 Enkidu93 requested review from ddaspit and johnml1135 March 6, 2025 19:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (0179f69) to head (6234a00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   70.41%   70.42%           
=======================================
  Files         386      386           
  Lines       32204    32204           
  Branches     4531     4531           
=======================================
+ Hits        22677    22680    +3     
+ Misses       8480     8478    -2     
+ Partials     1047     1046    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test that covers the bug we are fixing here?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

Copy link
Copy Markdown
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry for the delay - it took me way longer than it should have to find a minimal test to cause this to happen. I confirmed that this test fails when run with the previous code.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @johnml1135)

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93 Enkidu93 merged commit d1b6af6 into master Mar 7, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the wa_e2e_fixes branch March 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants