Improve build warnings (esp. USFM versification errors)#847
Conversation
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
src/Machine/src/Serval.Machine.Shared/Services/NmtPreprocessBuildJob.cs line 90 at r1 (raw file):
); int maxWarnings = 100;
Yes, let's make this configurable. One hundred seems a bit low. Maybe 1000.
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/IParallelCorpusPreprocessingService.cs line 7 at r1 (raw file):
QuoteConventionAnalysis? AnalyzeTargetCorpusQuoteConvention(ParallelCorpus corpus); IReadOnlyList<(string CorpusId, IReadOnlyList<UsfmVersificationError> Errors)> AnalyzeUsfmVersification( ParallelCorpus parallelCorpus
I appreciate these small changes that incrementally improve the quality of the codebase.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 12 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
author Enkidu93 <lowryec17@gcc.edu> 1765920252 -0500 committer Enkidu93 <lowryec17@gcc.edu> 1766155017 -0500 Cap the number of warnings to 100; add project name to warning and reformat warning message for better readability; Only generate warnings for each file once Add max warnings to build options; fix filtering logic; add tests Fix version typo
6416a7e to
5a61c4d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 66.11% 66.18% +0.07%
==========================================
Files 382 382
Lines 20744 20789 +45
Branches 2711 2719 +8
==========================================
+ Hits 13714 13759 +45
Misses 6066 6066
Partials 964 964 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Partial fix of #844. Requires sillsdev/machine#368. Fixes #841.
Includes:
This change is