Open
Conversation
ddaspit
approved these changes
Apr 14, 2026
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how I missed this! I think I got so caught up in the refactoring that I forgot to add rigorous tests for the most essential change 😵. Added tests to cover this case as well as a couple other things I noticed were not covered.
Fixes #903.
I did not de-duplicate the warnings since after thinking about it more, I wasn't sure if it'd be helpful to see whether this is affecting both SF parallel corpora or just one. Unlike duplicating the versification warnings which could become sizable, this would only ever be one extra message, so I don't know that it's worth it, but I'm open to changing my mind.
This change is