Skip to content

FIX Allow convertSearchToArray to handle repeating elements #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikenuguid wants to merge 1 commit into
base: 1.13
Choose a base branch
from
Open

FIX Allow convertSearchToArray to handle repeating elements #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/dist/js/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 17 additions & 6 deletions client/src/legacy/sspath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,27 @@ var $window = $( window ),
},

// Converts query strings (foo=bar&baz=bla) to a hash.
// TODO Handle repeating elements (e.g. arr[]=one&arr[]=two)
// 2013-12-06 ischommer: Added to allow merge with existing keys
convertSearchToArray: function(search) {
var parts, i, tmp, params = {};
var parts, i, tmp, key, value, params = {};
search = search.replace( /^\?/, '' );
parts = search ? search.split( '&' ) : [];
for(i=0; i < parts.length; i++) {
tmp = parts[i].split( '=' );
params[decodeURIComponent(tmp[0])] = decodeURIComponent(tmp[1]);

for(i = 0; i < parts.length; i++) {
tmp = parts[i].split('=');
key = decodeURIComponent(tmp[0]);
value = decodeURIComponent(tmp[1]);

// Check if key exists and add value if it does.
if (key in params) {
if (!Array.isArray(params[key])) {
params[key] = [params[key]];
}
params[key].push(value);
} else {
params[key] = value;
}
}

return params;
},

Expand Down