Skip to content

FIX HasManyList namespace#405

Open
ntd wants to merge 1 commit into
silverstripe:5from
ntd:fix-HasManyList
Open

FIX HasManyList namespace#405
ntd wants to merge 1 commit into
silverstripe:5from
ntd:fix-HasManyList

Conversation

@ntd

@ntd ntd commented Feb 27, 2026

Copy link
Copy Markdown

Description

When viewing a post with comments, I get the following error:

error-log.ERROR: Uncaught Exception TypeError: "SilverStripe\Comments\Model\Comment::AllReplies(): Return value must be of type ?SilverStripe\Model\List\HasManyList, SilverStripe\ORM\HasManyList returned" at ...

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant