Skip to content

ENH Use Environment::isCli() instead of Director::is_cli() #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emteknetnz wants to merge 1 commit into
base: 7
Choose a base branch
from
+2 −2
Open

ENH Use Environment::isCli() instead of Director::is_cli() #1449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/Extension/UpgradePolymorphicExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace SilverStripe\UserForms\Extension;

use SilverStripe\Control\Director;
use SilverStripe\Core\Environment;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Core\Extension;
use SilverStripe\ORM\DataList;
Expand Down Expand Up @@ -98,7 +98,7 @@ protected function onRequireDefaultRecords()

if ($updated) {
$message = "Corrected {$updated} default polymorphic class names to {$this->defaultReplacement}";
if (Director::is_cli()) {
if (Environment::isCli()) {
echo sprintf(" * %s\n", $message);
} else {
echo sprintf("<li>%s</li>\n", $message);
Expand Down
Loading