Skip to content

Use valid_data in metrics #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmccrackan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use valid_data in metrics #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions sotodlib/qa/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def __init__(
# extract parameters
self._tags = process_args.get("tags", {})
self._thresh = process_args.get("thresh", 0.75)
self._key = process_args.get("process_name", "glitches")
self._key = process_args.get("process_name", "")

def _process(self, meta):

Expand Down Expand Up @@ -227,10 +227,18 @@ def _process(self, meta):

if len(subset) > 0:
# Compute the number of samples that are valid
frac_valid = np.array([
np.dot(r.ranges(), [-1, 1]).sum() / len(subset)
for r in meta.preprocess[self._key].valid[subset]
])
if self._key:
frac_valid = np.array([
np.dot(r.ranges(), [-1, 1]).sum() / len(subset)
for r in meta.preprocess[self._key].valid[subset]
])
elif "valid_data" in meta.preprocess:
frac_valid = np.array([
np.dot(r.ranges(), [-1, 1]).sum() / len(subset)
for r in meta.preprocess.valid_data.valid_data[subset]
])
else:
raise Exception("No field to calculate valid detectors.")

# Count detectors with fraction valid above threshold
n_good = (frac_valid > self._thresh).sum()
Expand Down