Update source flags handling#1620
Draft
mmccrackan wants to merge 1 commit intomasterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates source flags handling to only create a mask centered on the point source instead of being centered at (0, 0) which causes LAT preprocessing to fail due to the mask being too large. Thanks to Matthew Hasselfield for helping work through this.
Testing with Moon flags on:
obs_id = "obs_1723949339_satp3_1111111"
dets = {'wafer_slot': 'ws5', 'wafer.bandpass': 'f150'}
This gives the exact same answer between the new and old version when the roll is not included in
scan_q_modelbut differs slightly when included.