Skip to content

[Devourer] Soul Fragments automatically pickup if activated inside pickup range #11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 4 commits into from
Aug 13, 2026
+16 −1
Merged

[Devourer] Soul Fragments automatically pickup if activated inside pickup range #11359

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29c34b4
[Devourer] Soul Fragments automatically pickup if activated inside pi…
Aezeor Apr 11, 2026
2ac3261
Merge branch 'simulationcraft:midnight' into soul-fragment
Aezeor Aug 12, 2026
bf1c6f6
[Devourer] Update base soul fragment distance
Aezeor Aug 12, 2026
4cb582b
reorder autocollection sequence
Aezeor Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,7 @@ class demon_hunter_t : public parse_player_effects_t
proc_t* soul_fragment_from_reapers_toll;
proc_t* soul_fragment_from_void_metamorphosis;
proc_t* soul_fragment_from_entropy;
proc_t* soul_fragment_auto_pickup;
std::unordered_map<std::string, proc_t*> shattered_souls;

// Havoc
Expand Down Expand Up @@ -1707,6 +1708,15 @@ struct soul_fragment_t

frag->activate = nullptr;
frag->expiration = make_event<fragment_expiration_t>( sim(), frag );

// Devourer souls automatically get picked up if they activate inside the pickup range
if ( ( frag->dh->specialization() == DEMON_HUNTER_DEVOURER ) && ( frag->get_distance( frag->dh ) <= 4.0 ) )
{
frag->consume_on_activation = true;

frag->dh->proc.soul_fragment_auto_pickup->occur();
}

frag->dh->activate_soul_fragment( frag );
}
};
Expand Down Expand Up @@ -1804,12 +1814,15 @@ struct soul_fragment_t
void set_position()
{
// Base position is up to 15 yards to the front right or front left for Vengeance, 9.5 yards for Havoc
// 08/12/2026: Devourer base distance appears to be slightly larger than Havoc, needs further testing but
// distance=5.6066 results in similar automatic soul pickups to ingame

double distance = 0;
double dist;
switch ( dh->specialization() )
{
case DEMON_HUNTER_DEVOURER:
distance = 4.6066;
distance = 5.6066;
break;
case DEMON_HUNTER_HAVOC:
distance = 4.6066;
Expand Down Expand Up @@ -10565,6 +10578,7 @@ void demon_hunter_t::init_procs()
proc.soul_fragment_from_reapers_toll = get_proc( "Soul Fragment from Reaper's Toll" );
proc.soul_fragment_from_void_metamorphosis = get_proc( "Soul Fragment from Void Metamorphosis" );
proc.soul_fragment_from_entropy = get_proc( "Soul Fragment from Entropy" );
proc.soul_fragment_auto_pickup = get_proc( "Soul Fragment Auto Pickup" );

// Havoc
proc.soul_fragment_from_demonic_appetite = get_proc( "Soul Fragment from Demonic Appetite" );
Expand Down Expand Up @@ -12951,6 +12965,7 @@ class demon_hunter_report_t : public player_report_extension_t
p.proc.soul_fragment_from_reapers_toll,
p.proc.soul_fragment_from_void_metamorphosis,
p.proc.soul_fragment_from_entropy,
p.proc.soul_fragment_auto_pickup,

// havoc
p.proc.soul_fragment_from_demonic_appetite,
Expand Down
Loading