fix: normalize confidence case across config filtering and semantic output#73
Open
Ty-Robb wants to merge 1 commit intosinewaveai:mainfrom
Open
fix: normalize confidence case across config filtering and semantic output#73Ty-Robb wants to merge 1 commit intosinewaveai:mainfrom
Ty-Robb wants to merge 1 commit intosinewaveai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize confidence casing so threshold filtering behaves consistently across engines, including semantic findings.
Problem
Semantic integration can emit lowercase confidence (for example
medium) while threshold checks use uppercase levels (LOW|MEDIUM|HIGH). This can cause findings to be filtered incorrectly.Changes
src/config.jsconfidence_thresholdto uppercase inmeetsConfidenceThreshold.src/semantic-integration.jsMEDIUMdefault).tests/config.test.jsMEDIUMthreshold.Verification
npx vitest run tests/config.test.js(pass)npx vitest run tests/scan-security.test.js tests/semantic-analysis.test.js(pass)Fixes #70