Skip to content

Fix: metta mork loader error #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levisingularity merged 3 commits into from
Apr 7, 2026
Merged

Fix: metta mork loader error #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
294e672
fix metta mork loader error
levisingularity Apr 7, 2026
c25efa9
remove comments
levisingularity Apr 7, 2026
401a77f
restore all tests
levisingularity Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions das-cli/src/common/container_manager/metta/metta_loader_container_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(
self._options = options

def _gen_metta_loader_command(self, filename: str) -> str:
skip_redis = "--skip-redis" if self._options.get('atomdb_backend') == 'mork_mongodb' else ""
skip_redis = "--skip-redis" if self._options.get('atomdb_backend') == 'morkmongodb' else ""
exec_command = f"db_loader {filename} {skip_redis}".strip()

return exec_command
Expand Down Expand Up @@ -60,7 +60,7 @@ def start_container(self, path):
},
},
stdin_open=True,
tty=True,
tty=False,
auto_remove=False,
)

Expand Down
21 changes: 21 additions & 0 deletions das-cli/tests/integration/test_metta.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,25 @@ setup() {
assert_line --partial "das-cli-mongodb-${mongodb_port} is not running on port ${mongodb_port}"

assert_line --partial "Please use 'db start' to start required services before running 'metta load'."
}

@test "Loading MeTTa file using MORK_MONGODB backend (skip redis)" {
local metta_file_path="$test_fixtures_dir/metta/animals.metta"

update_json_key "$das_config_file" "atomdb.backend" "morkmongodb"

local mongodb_endpoint="$(get_config .atomdb.mongodb.endpoint)"
local mongodb_port="$(extract_port "$mongodb_endpoint")"

das-cli db start
sleep 10s

run das-cli metta load "$metta_file_path"

assert_line --partial "das-cli-mongodb-${mongodb_port} is running on port ${mongodb_port}"

assert_line --partial "Loading metta file ${metta_file_path}..."
assert_line --partial "Done loading."

assert_success
}
Loading