Fix crashing and potential invalid intermediate cudf expr in cudf_join#39
Merged
Conversation
… conjunction in cudf_join
bwyogatama
approved these changes
Jun 1, 2025
akashmaji946
added a commit
to akashmaji946/rasterdb
that referenced
this pull request
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues in
cudf_join.cu:cudf_mixed_join, make the scope ofcolumn_referencescorrect which are used to constructcudf::ast::ast_operator, however,cudf::ast::ast_operatoronly takes the references so the caller needs to own the objects.final_expr). For the same reason as above, all intermediate cudf exprs should be owned by the caller.