Skip to content

ci(test): add S3 integration gate to the merge-queue test workflow #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mbrobbel wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

ci(test): add S3 integration gate to the merge-queue test workflow #915

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18c3ff8
ci(test): add S3 integration gate to the merge-queue test workflow
mbrobbel Jun 10, 2026
85011b0
ci(test): start Docker daemon before S3 integration steps
mbrobbel Jun 10, 2026
5235e5f
ci(test): replace daemon-start step with docker info check
mbrobbel Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
run-on-pr: ${{ fromJSON(github.event_name == 'pull_request' && 'false' || 'null') }}
fail-fast: false
runs-on: ${{ fromJSON(format('["self-hosted", "{0}", "gpu-2xl4"]', matrix.cuda.runner)) }}
timeout-minutes: 60
timeout-minutes: 90
env:
CUDA_CACHE_PATH: /home/runner/actions-runner/_work/.cuda-cache
SIRIUS_LOG_LEVEL: trace
Expand Down Expand Up @@ -178,6 +178,27 @@ jobs:
path: ${{ steps.tpch.outputs.run_dir }}
retention-days: 14

# S3 integration gate (issue #904).
# Requires the Docker daemon to be running on the runner (testcontainers
# starts MinIO via the Docker socket). Infra tracks enabling this on the
# gpu-2xl4 runners; the diagnostic step below will turn green once done.
#
# Phase 1: run on this branch's CUDA-13 test-run.
# Phase 2 (before merge): gate each step behind
# github.event_name == 'merge_group' &&
# so PR CI stays Docker-free and only the merge queue pays the MinIO cost.
- name: Check Docker availability
if: ${{ matrix.cuda.version == '13' }}
run: docker info

- name: S3 integration tests
if: ${{ matrix.cuda.version == '13' }}
run: make s3-test

- name: S3 large SQL-over-S3 tests
if: ${{ matrix.cuda.version == '13' }}
run: make s3-test-large

test:
runs-on: ubuntu-slim
needs: test-run
Expand Down
Loading