Refactor LED toggle functionality in network.py to use DeviceSetLedStatus with fallback - #82
Merged
Merged
Conversation
…ity with older UniFi Network versions. Implemented a dual approach using DeviceSetLedStatus with a fallback to a minimal payload, enhancing error handling and logging for better debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the
set_device_ledmethod incustom_components/unifi_network_rules/udm/network.pyto improve its robustness and flexibility. It introduces a two-step approach for toggling the LED status of a device, prioritizing a new method (DeviceSetLedStatus) with a fallback to the original minimal payload approach.fixes #80
Enhancements to LED toggle functionality:
DeviceSetLedStatusfromaiounifi. This method provides a more structured and modern way to interact with the UniFi API.Logging improvements:
Error handling improvements: