Fix connection not being detached - #154
Merged
Merged
Conversation
When a client connection's WebSocket handshake fails in acceptSocket(), the Connection was attached to the Runner but never detached on failure — only connection->disconnect() was called. This left a dead entry in the runner that could trigger RunnerException on port reuse. Add runner->detach() to the handshake failure catch block so the entry is cleaned up eagerly rather than relying on lazy replacement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
This would make sense at least in terms of how it is described in the commit message. Meanwhile I cleaned up our onClose / onDisconnect, which reduced some other errors I've been seeing, but not the RunnerException counts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handshake failed, connection was closed but wasn't detached from the listener.