[AI review experiment] upstream PR #9612#3
Conversation
Drive row details and single-selection from the grid's cell-activate and row-activate events instead of two activeItem property observers. Reading detailsOpened and selected straight from the activated item decouples details from selection and fixes three cases: - Details now close when clicking a row whose details are open even if deselect is disallowed; before, reverting activeItem stopped the details observer from running. - Selecting an item from server data no longer opens its details; before, the programmatic activeItem change triggered the observer. - Clicking a row with details opened from data now closes them in a single click. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ven in tests — from clicking the first cell to dispatching the `row-activate` event (the keyboard activation path), plus new tests for Space-key row selection. test: drive grid single-selection via row-activate event - decouple testbench select/deselect from cell clicks so it no longer triggers item-click listeners as a side effect - add tests for selecting and deselecting a row with the Space key
`destroyData` removed the item from the visible-details set, so details closed after the item left and re-entered the DOM (parent row collapse/expand, or scrolling out of and back into view).
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Throwaway PR for AI code-review experiment.
Reconstructs the pre-review state of vaadin#9612 at commit
084d19abcb892744ae56ca4f069f1a078cc25381.Do not merge.