Skip to content

Change the maintainer of TinkMingKing/siyuan-plugins-index to Szerelem0617#1739

Merged
TCOTC merged 1 commit into
siyuan-note:mainfrom
Szerelem0617:patch-1
Jan 30, 2026
Merged

Change the maintainer of TinkMingKing/siyuan-plugins-index to Szerelem0617#1739
TCOTC merged 1 commit into
siyuan-note:mainfrom
Szerelem0617:patch-1

Conversation

@Szerelem0617

Copy link
Copy Markdown
Contributor

目录插件后续将由我来进行维护,更新一下插件作者信息

@github-actions

Copy link
Copy Markdown

Pull Request Check Report

Add 0 Icon Repo

Add 1 Plugin Repo

Szerelem0617/siyuan-plugins-index

  • Release that must exist
    • Current Latest Release
    • package.zip
  • Files that must exist
    • plugin.json
    • icon.png
    • preview.png
    • README.md
  • Attributes that must exist in plugin.json
    • name
      • The attribute exists
      • Is a valid name
      • Not conflict with other plugin name
    • version
    • author
    • url

Add 0 Template Repo

Add 0 Theme Repo

Add 0 Widget Repo

@TCOTC

TCOTC commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

仓库名请与旧的包名保持一致,你少了一个 s:

PixPin_2026-01-29_20-12-56

PixPin_2026-01-29_20-10-50

@TCOTC TCOTC self-requested a review January 29, 2026 12:13
@TCOTC TCOTC changed the title Update plugin repository owner info in plugins.json Change the maintainer of TinkMingKing/siyuan-plugins-index to Szerelem0617 Jan 29, 2026
@TCOTC

TCOTC commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

另外,因为该插件新版本元数据中记录了错误的仓库链接,所以安装了新版本插件的用户都无法在 已下载 界面中更新插件,请及时更正仓库名并且更正元数据,提升版本号重新发版:

安装集市包 [siyuan-plugins-index] 失败:get bazaar package failed: 404 Not Found

PixPin_2026-01-29_20-29-09

@Szerelem0617

Copy link
Copy Markdown
Contributor Author

感谢大佬指点,以更新仓库名和版本号

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

url 仍然是错误的 https://github.com/Szerelem617/siyuan-plugins-index

还有别的错误,我一起说了你再改吧

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator
  • index.ts 缺少 uninstall 方法用于删除 config 文件,参考:https://github.com/siyuan-note/plugin-sample/blob/ca751dedb8f9e6d2b1db64c25b98f4f5cf3a2773/src/index.ts#L263-L269

  • 两个 README 文件中的几个超链接的 owner 都是错的,无法打开

  • icon.png 应小于 20KB

  • LICENSE 的版权信息需要修改

  • 修改 plugin.json:

     {
       "name": "siyuan-plugins-index",
       "author": "Szerelem617",
       "url": "https://github.com/Szerelem617/siyuan-plugins-index", // owner 错误
       "version": "1.8.3",
       "minAppVersion": "2.10.12", // 提升到最近的 3.x 版本
       "backends": ["all"],
       "frontends": ["all"],
       "displayName": {
         "default": "Index Plugin",
         "zh_CN": "目录插件"
       },
       "description": {
         "default": "One click insert a index list in document",
         "zh_CN": "一键在文档中插入目录或大纲列表"
       },
       "readme": {
         "default": "README.md",
         "zh_CN": "README_zh_CN.md"
       },
       "i18n": [ // 删除该字段
         "en_US",
         "zh_CN"
       ],
       "funding": { // 删除该字段
         "openCollective": "",
         "patreon": "",
         "github": ""
       },
       "keywords": [
         "index", "目录"
       ]
     }

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator
  • 打开文档时会读取两次 config 文件。请改为仅在插件启动时和 onDataChanged 时加载配置,在内存里维护配置

    PixPin_2026-01-30_13-14-02

  • 打开文档时会进行两次 sql 查询,如果查询到结果的话还会再重复进行一次 sql 查询。请优化为仅进行一次查询(一次查询就能获取到需要的数据了):

    PixPin_2026-01-30_13-18-38

@Szerelem0617

Copy link
Copy Markdown
Contributor Author

再次感谢大佬细致的反馈,除了icon图片,其它的问题我都尝试修复了;icon图片的问题我会在之后的版本更新。

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

v1.8.6 插件安装之后无法使用:

PixPin_2026-01-30_15-50-24

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

owner 还是错的,你甚至不知道自己的用户名吗 😂

PixPin_2026-01-30_15-29-46

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

plugin.json 里面还需要增加一行 "disabledInPublish": true,

@Szerelem0617

Copy link
Copy Markdown
Contributor Author

我又更新了下😫

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator
  • 在没有子文档/没有标题块的文档中插入目录或大纲时,仅有控制台日志。需要 showMessage() 提示用户

  • 打开文档时有三次 SQL 查询,需要优化:

    PixPin_2026-01-30_16-39-31

@Szerelem0617

Copy link
Copy Markdown
Contributor Author
  • 打开文档时有三次 SQL 查询,需要优化:

好的大佬,已更新

@TCOTC TCOTC merged commit 789ac6f into siyuan-note:main Jan 30, 2026
1 check passed
@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

感谢你的贡献,思源有你更精彩!
Thank you for your contribution. SiYuan will be more wonderful with you!

@TCOTC

TCOTC commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

后面记得把 icon.png 改到小于 20KB

@Szerelem0617

Copy link
Copy Markdown
Contributor Author

后面记得把 icon.png 改到小于 20KB

好滴,下周会改的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants