Support overriding digitiser sample-bits and samples-per-heap in scratch scripts - #1063
Support overriding digitiser sample-bits and samples-per-heap in scratch scripts#1063bmerry wants to merge 5 commits into
Conversation
|
Marking as draft because it will require ska-sa/katsdpcontroller#847 first. |
amishatishpatel
left a comment
amishatishpatel
left a comment
There was a problem hiding this comment.
I can't spot any outstanding references to DIG_SAMPLE_BITS (that haven't been updated to the new DEFAULT_DIG_SAMPLE_BITS). Same story for DIG_HEAP_SAMPLES.
Should we be expecting a katsdpcontroller PR some time soon?
| --adc-sample-rate ${adc_sample_rate:-7000000000} \ | ||
| --adc-sample-rate ${adc_sample_rate:-5992000000} \ | ||
| --sample-bits ${dig_sample_bits:-6} \ | ||
| --heap-samples ${dig_heap_samples:-8192} \ |
There was a problem hiding this comment.
Just out of interest, and because I never really dabbled in the higher adc_sample_rates
- What were the possible/usual values tested?
- I take it the tweaks to the
*-hbw.shscripts imply Band 5B as default.
There was a problem hiding this comment.
7 Gsps was I think just 4x S-band (and about the limit of what the current hardware can achieve. 5.992 Gsps is I believe the Band 5B rate.
It's already been reviewed by Eaton: ska-sa/katsdpcontroller#847 |
Prefix them with DEFAULT_ to emphasise that these are not the only possible values. That was already the case, but there is still a lot of test/qualification/scratch code that assumes these default values.
Use them in the command-line parsers for fgpu and dsim, to ensure that they have consistent defaults with each other.
This depends on product-configure schema 4.9, which is not yet in production.
c02371d to
c5e966b
Compare
2 participants
Checklist (if not applicable, edit to add
(N/A)and mark as done):pyproject.tomland.pre-commit-config.yaml.fake_servers.pyin katsdpcontroller to match.VERSION constant for the engine (update the major number if sensors/requests have been
removed/changed, minor number if only backwards-compatible changes have been done).
Also, update doc/control.rst with the new version.
Closes NGC-1796.