Skip to content

Cancel .task task on dispose, instead of crashing the app #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcprux merged 1 commit into from
May 14, 2026
Merged

Cancel .task task on dispose, instead of crashing the app #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions Sources/SkipUI/SkipUI/View/AdditionalViewModifiers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.SideEffect
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.rememberUpdatedState
Expand Down Expand Up @@ -1351,8 +1350,13 @@ extension View {
#if SKIP
return ModifiedContent(content: self, modifier: SideEffectModifier { _ in
let handler = rememberUpdatedState(action)
LaunchedEffect(value) {
handler.value()
DisposableEffect(value) {
let task = Task(priority: priority) {
handler.value()
}
onDispose {
task.cancel()
}
}
return ComposeResult.ok
})
Expand All @@ -1366,15 +1370,20 @@ extension View {
#if SKIP
return ModifiedContent(content: self, modifier: SideEffectModifier { _ in
let actionState = rememberUpdatedState(bridgedAction)
LaunchedEffect(value) {
kotlinx.coroutines.suspendCancellableCoroutine { continuation in
let completionHandler = CompletionHandler({
do { continuation.resume(Unit, nil) } catch {}
})
continuation.invokeOnCancellation { _ in
completionHandler.onCancel?()
DisposableEffect(value) {
let task = Task {
kotlinx.coroutines.suspendCancellableCoroutine { continuation in
let completionHandler = CompletionHandler({
do { continuation.resume(Unit, nil) } catch {}
})
continuation.invokeOnCancellation { _ in
completionHandler.onCancel?()
}
actionState.value(completionHandler)
}
actionState.value(completionHandler)
}
onDispose {
task.cancel()
}
}
return ComposeResult.ok
Expand Down