Skip to content

Ruby 4.0.0 ready #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctrochalakis merged 2 commits into from
Dec 10, 2025
Merged

Ruby 4.0.0 ready #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1a9750
gha: bump setup-ruby to latest (supports ruby4)
ctrochalakis Nov 22, 2025
2e6eaa8
worker,supervisor: refactor shutdown signaling mechanics
ctrochalakis Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

- uses: ruby/setup-ruby@44511735964dcb71245e7e55f72539531f7bc0eb # v1
- uses: ruby/setup-ruby@8aeb6ff8030dd539317f8e1769a044873b56ea71 # v1
env:
RSPEC_CORE: ${{ matrix.rspec-core-version }}
with:
Expand Down
5 changes: 4 additions & 1 deletion lib/rspecq/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ def initialize(build_id:, worker_id:, redis_opts:, shutdown_pipe: nil)
end

def shutdown?
@shutdown_pipe&.ready?
return false if @shutdown_pipe.nil?

# returns :wait_readable if the supervisor has not signaled shutdown (closed the writer)
@shutdown_pipe.read_nonblock(1, exception: false).nil?
end

def work
Expand Down