Implement per build timings#96
Merged
Merged
Conversation
ctrochalakis
force-pushed
the
per-build-timings
branch
from
a75bc22 to
d6fe7d3
Compare
ctrochalakis
force-pushed
the
per-build-timings
branch
from
f2fc7c8 to
0877f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #95 for more information.
Note that we now move the
timingscmdline flag to the reporter, since the copy of the timings key happens in the reporter process.Alternatively, we could keep the cmdline flag to the worker(s). The master worker would set a flag in the redis config, and the reporter would pick that flag, and move the key.