ENH: add isolated test for filter_tags in all_objects#510
Open
shourya1419-netizen wants to merge 6 commits intosktime:mainfrom
Open
ENH: add isolated test for filter_tags in all_objects#510shourya1419-netizen wants to merge 6 commits intosktime:mainfrom
shourya1419-netizen wants to merge 6 commits intosktime:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an isolated regression test to ensure that filter_tags used within all_objects does not return empty results unexpectedly.
Why is this needed?
Previously, changes in unrelated parts of the codebase could cause filter_tags behavior in all_objects to break silently. This test ensures that the filtering logic continues to return the expected objects when tags are applied.
Changes
1)Added a dedicated test case for filter_tags behavior within all_objects.
2)Ensures results are not empty when valid tags are provided.
3)Helps prevent regressions in tag filtering logic.
Fixes #162