🧹 Remove unused _strip_known_texture_extensions#53
Conversation
…ssor.py` Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR removes dead code from the texture processing pipeline and cleans up the test suite’s requests mocking so retry behavior is exercised consistently.
Changes:
- Removed unused
TextureProcessor._strip_known_texture_extensionsfromtexture_processor.py. - Removed now-obsolete unit tests covering
_strip_known_texture_extensions. - Updated
tests/test_remix_api.pymock exception hierarchy so retry logic catches the mocked exceptions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
texture_processor.py |
Deletes an unused helper method to reduce maintenance surface. |
tests/test_texture_processor.py |
Removes tests for the deleted helper. |
tests/test_remix_api.py |
Adjusts mocked requests.exceptions.* inheritance to match make_request’s exception handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| sys.modules.setdefault("requests", _req_mock) | ||
|
|
🎯 What: Removed the unused
_strip_known_texture_extensionsstatic method fromtexture_processor.py, along with its associated unit tests intests/test_texture_processor.py. Also fixed the test suite mock exception inheritance for requests intests/test_remix_api.pyto pass tests successfully.💡 Why: To eliminate dead code and improve code health/maintainability.
✅ Verification: Ran
pytestandpython3 -m unittest discover teststo ensure the test suite is fully green and no functionality broke.✨ Result: A cleaner
texture_processor.pyand test suite without untested or dead code, and standardizing requests mock exceptions.PR created automatically by Jules for task 9765888511104902227 started by @skurtyyskirts