Skip to content

🧹 Remove unused _strip_known_texture_extensions#53

Open
skurtyyskirts wants to merge 1 commit into
mainfrom
remove-unused-strip-texture-extensions-9765888511104902227
Open

🧹 Remove unused _strip_known_texture_extensions#53
skurtyyskirts wants to merge 1 commit into
mainfrom
remove-unused-strip-texture-extensions-9765888511104902227

Conversation

@skurtyyskirts

Copy link
Copy Markdown
Owner

🎯 What: Removed the unused _strip_known_texture_extensions static method from texture_processor.py, along with its associated unit tests in tests/test_texture_processor.py. Also fixed the test suite mock exception inheritance for requests in tests/test_remix_api.py to pass tests successfully.
💡 Why: To eliminate dead code and improve code health/maintainability.
Verification: Ran pytest and python3 -m unittest discover tests to ensure the test suite is fully green and no functionality broke.
Result: A cleaner texture_processor.py and test suite without untested or dead code, and standardizing requests mock exceptions.


PR created automatically by Jules for task 9765888511104902227 started by @skurtyyskirts

…ssor.py`

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 3, 2026 03:47
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes dead code from the texture processing pipeline and cleans up the test suite’s requests mocking so retry behavior is exercised consistently.

Changes:

  • Removed unused TextureProcessor._strip_known_texture_extensions from texture_processor.py.
  • Removed now-obsolete unit tests covering _strip_known_texture_extensions.
  • Updated tests/test_remix_api.py mock exception hierarchy so retry logic catches the mocked exceptions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
texture_processor.py Deletes an unused helper method to reduce maintenance surface.
tests/test_texture_processor.py Removes tests for the deleted helper.
tests/test_remix_api.py Adjusts mocked requests.exceptions.* inheritance to match make_request’s exception handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_remix_api.py
Comment on lines +19 to 21

sys.modules.setdefault("requests", _req_mock)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants