Skip to content

test: Close coverage gaps for full test coverage#96

Open
lucas-manuel wants to merge 1 commit intodevfrom
add-missing-coverage-2
Open

test: Close coverage gaps for full test coverage#96
lucas-manuel wants to merge 1 commit intodevfrom
add-missing-coverage-2

Conversation

@lucas-manuel
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Coverage after merging add-missing-coverage-2 into dev will be

99.45%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ALMProxy.sol100%100%100%100%
   ALMProxyFreezable.sol100%100%100%100%
   AccessControls.sol100%100%100%100%
   Controller.sol100%100%100%100%
   ControllerSharedStorage.sol100%100%100%100%
   PAUFactory.sol100%100%100%100%
   RateLimits.sol100%100%100%100%
src/facets
   FacetBase.sol100%100%100%100%
src/facets/aave
   AaveFacet.sol100%100%100%100%
src/facets/cctp
   CCTPFacet.sol100%100%100%100%
src/facets/centrifuge
   CentrifugeFacet.sol100%100%100%100%
src/facets/curve
   CurveFacet.sol100%100%100%100%
src/facets/dai-usds
   DAIUSDSFacet.sol100%100%100%100%
src/facets/erc4626
   ERC4626Facet.sol98.28%92.31%100%100%200
src/facets/erc7540
   ERC7540Facet.sol100%100%100%100%
src/facets/farm
   FarmFacet.sol100%100%100%100%
src/facets/layer-zero
   LayerZeroFacet.sol97.06%83.33%100%100%226
src/facets/maple
   MapleFacet.sol100%100%100%100%
src/facets/merkl
   MerklFacet.sol100%100%100%100%
src/facets/otc
   OTCBuffer.sol89.66%100%85.71%88.89%92, 98
   OTCFacet.sol100%100%100%100%
src/facets/pendle
   PendleFacet.sol100%100%100%100%
src/facets/psm
   PSMFacet.sol100%100%100%100%
src/facets/psm3
   PSM3Facet.sol100%100%100%100%
src/facets/spark-vault
   SparkVaultFacet.sol100%100%100%100%
src/facets/superstate
   SuperstateFacet.sol100%100%100%100%
src/facets/transfer-asset
   TransferAssetFacet.sol100%100%100%100%
src/facets/uniswap-v3
   UniswapV3Facet.sol99.29%96.92%100%100%855–856
   UniswapV3Utils.sol96.36%77.78%100%100%155, 56
src/facets/uniswap-v4
   UniswapV4Facet.sol100%100%100%100%
src/facets/usde
   USDEFacet.sol100%100%100%100%
src/facets/usds
   USDSFacet.sol100%100%100%100%
src/facets/weeth
   WEETHFacet.sol100%100%100%100%
   WEETHModule.sol87.76%90%87.50%87.10%106, 154, 160–162
src/facets/wrap-proxy-eth
   WrapProxyETHFacet.sol100%100%100%100%
src/facets/wsteth
   WSTETHFacet.sol100%100%100%100%
src/libraries
   ApproveLib.sol100%100%100%100%

Comment thread test/unit/OTCBuffer.t.sol

vm.expectRevert(abi.encodeWithSignature(
"AccessControlUnauthorizedAccount(address,bytes32)",
address(this),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use this, but rather prank from unauthorized.


vm.expectRevert(abi.encodeWithSignature(
"AccessControlUnauthorizedAccount(address,bytes32)",
address(this),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use this, but rather prank from unauthorized.

@sunbreak1211
Copy link
Copy Markdown

@lucas-manuel wondering if in integration/Controller.t.sol would make sense to rename mul and div from MockFacet1 and MockFacet2 to mul1, div1, mul2, and div2 respectively. That way it can better asserted that the selector is correctly updated in the different back and forth scenarios of the fallback story test. I don't think it is really needed to collide on the delegate selector to test anything, only interesting in the call one side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants