Conversation
Comment on lines
+252
to
+254
| // ================================== | ||
| // Relay functions (L1 → L2) | ||
| // ================================== |
There was a problem hiding this comment.
Did you consider moving the relay functions to its own file library? It seems that would be cleaner for L2 where the relay functions do not apply but would also separate better the concerns in L1.
There was a problem hiding this comment.
After a quick try it seems the split is pretty straight forward. Anyway not a real strong opinion but feels better to separate.
| @@ -0,0 +1,410 @@ | |||
| // SPDX-License-Identifier: AGPL-3.0-or-later | |||
| pragma solidity ^0.8.22; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.