Skip to content

Adjust checks to foundry based deploy#51

Merged
SidestreamBurningBanana merged 6 commits intomasterfrom
adjust-checks-to-foundry-based-deploy
Dec 24, 2025
Merged

Adjust checks to foundry based deploy#51
SidestreamBurningBanana merged 6 commits intomasterfrom
adjust-checks-to-foundry-based-deploy

Conversation

@SidestreamBurningBanana
Copy link
Copy Markdown
Contributor

This PR adjusts the checklist to account for the changes in the dapptools to Foundry migration

See the PR inside the spell repo: sky-ecosystem/spells-mainnet#491

Comment thread spell/spell-crafter-mainnet-workflow.md Outdated
Comment thread spell/spell-crafter-mainnet-workflow.md Outdated
@riccardopersiani riccardopersiani self-requested a review December 18, 2025 10:43
Copy link
Copy Markdown
Member

@riccardopersiani riccardopersiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things:

  • I am wondering if these occurrences should be updated as well: 
printenv | grep "FOUNDRY_\|DAPP_".

  • Also there are some dapp/dapptools findings in spell-crafter-goerli, example:

[ ] Pre-Deploy Setup and Checks (currently via `dapptools`)

@SidestreamColdMelon
Copy link
Copy Markdown
Contributor

@riccardopersiani

  • I am wondering if these occurrences should be updated as well: 
 printenv | grep "FOUNDRY_\|DAPP_".

No, foundry still has backward compatibility and reads/accepts env vars that start with DAPP_, see their project settings docs: https://getfoundry.sh/config/reference/project. So it's still crucial to check that those are not set to some unexpected values.

  • Also there are some dapp/dapptools findings in spell-crafter-goerli

Goerli-specific checklists are inside archived folder, we do not modify them.

@riccardopersiani riccardopersiani self-requested a review December 18, 2025 13:01
@SidestreamBurningBanana SidestreamBurningBanana merged commit 972b5a6 into master Dec 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants