Adjust checks to foundry based deploy#51
Merged
SidestreamBurningBanana merged 6 commits intomasterfrom Dec 24, 2025
Merged
Conversation
SidestreamColdMelon
approved these changes
Dec 17, 2025
riccardopersiani
approved these changes
Dec 18, 2025
Member
riccardopersiani
left a comment
There was a problem hiding this comment.
Two little things:
-
I am wondering if these occurrences should be updated as well:
printenv | grep "FOUNDRY_\|DAPP_". -
Also there are some dapp/dapptools findings in
spell-crafter-goerli, example:
[ ] Pre-Deploy Setup and Checks (currently via `dapptools`)
Contributor
No, foundry still has backward compatibility and reads/accepts env vars that start with
Goerli-specific checklists are inside archived folder, we do not modify them. |
riccardopersiani
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the checklist to account for the changes in the dapptools to Foundry migration
See the PR inside the spell repo: sky-ecosystem/spells-mainnet#491