Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
| Crafter | Spell code review is addressed, Exec Hash is added | 12:00 UTC Week 2 Wednesday |
| Reviewers | Spell code is reviewed (against the Exec Doc) | 16:00 UTC Week 2 Wednesday |
| Crafter | Spell is deployed, Testnet is created | 12:00 UTC Week 2 Thursday |
| Spell team | Spell development team having a sync call | 14:00-14:30 UTC Week 2 Thursday |
| Reviewers | Spell deployment is approved | 16:00 UTC Week 2 Thursday |
| Crafter | Spell address is published | 16:00-16:30 UTC Week 2 Thursday |
| Reviewers | Spell address is confirmed | 16:00-16:30 UTC Week 2 Thursday |
Expand Down Expand Up @@ -166,6 +167,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
* [ ] Make sure CI PASS
* [ ] Mark PR as "ready for review" and add reviewers
* [ ] Notify reviewers (e.g. "the spell is ready for review")
* [ ] Schedule sync call for Week 2 Thursday.

## Pre-Deployment Stage

Expand Down Expand Up @@ -236,6 +238,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
* A link to the deployed spell
* A link to the created Tenderly Testnet
* [ ] Notify the reviewers (e.g. "the spell was deployed")
* [ ] IF everything is on track, the sync call can be cancelled with agreement from the spell team

## Handover and Merge Stage

Expand Down
4 changes: 4 additions & 0 deletions spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
* `testVestSkyMint`
* `testVestUsds`
* `testVestSpk`
* IF `SKY` / `SPK` vest rewards distribution is present
* [ ] Rewards distribution contract address matches Exec Sheet
* [ ] To prevent front-running DoS, the `distribute()` call is placed inside `if` block that checks whether the vesting stream’s unpaid amount is greater than 0
* [ ] Tested via `testVestedRewardsDist`
* IF content related to a Prime Agent is present
* IF Prime Agent spell is provided
* [ ] Handover message matches `XXX spell YYYY-MM-DD deployed to 0x… with hash 0x…, direct execution: yes / no` template
Expand Down